locked mutex destroyed in dns-sd compat code

[Lurchi]

according to pthread_mutex_destroy(3p): "It shall be safe to destroy an initialized mutex that is unlocked. Attempting to destroy a locked mutex results in undefined behavior."

This may be causing some bugs (have seen some crashes) in the compat code. At least the "DNSServiceProcessResult(...)" function is affected.

Call graph: finish: sdref_unref() sdref_free() pthread_mutex_destroy() -> return, pthread_mutex_unlock()

Oh, and pthread_mutex_unlock uses sdref, which is freed in sdref_free() ...

[lennart]

The fix has already been available in SVN for a while:

http://avahi.org/browser/trunk/avahi-compat-libdns_sd/compat.c

will be contained in the next official release of Avahi.

(please check if it fixes all the issues you pointed out. I think it does, but please check and reopen this bug if necessary!)