Ticket #49 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

avahi uses deprecated dbus_connection_disconnect function

Reported by: lgoujon Owned by: lennart
Milestone: Avahi 0.6.12 Component: avahi-client
Keywords: Cc:

Description

In recent dbus builds, the dbus_connection_disconnect was removed and replaced by dbus_connection_close

Attachments

avahi_dbus.patch Download (1.7 KB) - added by lgoujon 7 years ago.
Patch to fix the problem

Change History

Changed 7 years ago by lgoujon

Patch to fix the problem

Changed 7 years ago by lennart

  • status changed from new to assigned

Mmmh, if we'd merge this patch we'd lose compatiblity with older DBUS versions, wouldn't we?

Could you please supply us with a patch that uses some kind of #ifdef to make sure compat is not broken? I would do that myself, but I don't have such new DBUS versions running here.

Changed 7 years ago by bkor

You will not lose compatability with older DBUS versions. As proof, see the blog by one of the dbus developers:  http://www.j5live.com/?p=231

dbus_connection_disconnect was deprecated and dbus_connection_close function existed for at least 1 year. Only now the deprecated function was removed. IMO patch should be applied as-is.

Changed 7 years ago by lennart

Hmm, we still support DBUS 0.3, I wonder if dbus_connection_close() was available in that version, too?

Changed 7 years ago by gregt

avahi requires dbus >= 0.34.

you can find dbus changelogs at  http://www.freedesktop.org/wiki/Software_2fDbusReleaseArchive changelog for 0.34 : "dbus_connection_disconnect is deprecated in favor of dbus_connection_close"

Changed 7 years ago by lennart

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in r1238

Changed 7 years ago by lennart

  • milestone set to Avahi 0.6.12
Note: See TracTickets for help on using tickets.