Ticket #302 (closed defect: fixed)

Opened 2 years ago

Last modified 20 months ago

[PATCH] Fix potential crash on service name collision.

Reported by: oc3an Owned by: lennart
Milestone: Avahi 0.6.26 Component: avahi-core
Keywords: Cc:

Description

Hello,

Here is a patch against the current master branch of the avahi git tree to fix a potential crash on service name collision.

This bug was introduced by commit f7e3b4fab6ba1bc98c6dbe859ccdef4fde6c5db2 (core: Bug fixes for cleanup code)

-Patrick

(I have attempted to send this patch to the mailing list but it doesn't seem to be working)

Attachments

Change History

Changed 20 months ago by lennart

Also see #276

Changed 20 months ago by oc3an

Hi lennart,

Are you planning on merging this into 0.6.26? There is a better description of what the patch fixes in the patch comment:

If there is a service name collision and the entry group callback calls avahi_s_entry_group_reset or avahi_s_entry_group free on the group in question, the entries were released. This could cause a crash in withdraw_rrset as it is walking a list of entries at this time.

The fix for this issue is to schedule a cleanup event to clean up entries after a short timeout (currently one second). If a cleanup occurs for any other reason the event is cancelled.

-Patrick

Changed 20 months ago by lennart

Yepp, this is the last bug I want to close for 0.6.26.

Changed 20 months ago by lennart

  • status changed from new to closed
  • resolution set to fixed

Applied your patch unmodified now. Thanks!

Note: See TracTickets for help on using tickets.