[PATCH] Fix potential crash on service name collision.

[oc3an]

Hello,

Here is a patch against the current master branch of the avahi git tree to fix a potential crash on service name collision.

This bug was introduced by commit f7e3b4fab6ba1bc98c6dbe859ccdef4fde6c5db2 (core: Bug fixes for cleanup code)

-Patrick

(I have attempted to send this patch to the mailing list but it doesn't seem to be working)

[lennart]

Also see #276

[oc3an]

Hi lennart,

Are you planning on merging this into 0.6.26? There is a better description of what the patch fixes in the patch comment:

If there is a service name collision and the entry group callback calls avahi_s_entry_group_reset or avahi_s_entry_group free on the group in question, the entries were released. This could cause a crash in withdraw_rrset as it is walking a list of entries at this time.

The fix for this issue is to schedule a cleanup event to clean up entries after a short timeout (currently one second). If a cleanup occurs for any other reason the event is cancelled.

-Patrick

[lennart]

Yepp, this is the last bug I want to close for 0.6.26.

[lennart]

Applied your patch unmodified now. Thanks!