Ticket #226 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

avahi-discover crashes if row is unselected

Reported by: james_w Owned by: lennart
Milestone: Avahi 0.6.24 Component: avahi-python
Keywords: Cc: jw+debian@…

Description

Hi,

In

https://bugs.launchpad.net/bugs/230337

a user reported that avahi-discover crashed for them.

Traceback (most recent call last):

File "/usr/bin/avahi-discover", line 64, in on_tree_view_cursor_changed

(name,interface,protocol,stype,domain) = self.treemodel.get(iter,1,2,3,4,5)

TypeError?: iter must be a GtkTreeIter?

I believe the cause of this was the a row was unselected, meaning that get_selection() returned None for iter, which then was used improperly in treemodel.get()

The attached patch should prevent this from happening. Please consider applying it.

Thanks,

James

Attachments

avahi-discover.diff (0.7 kB) - added by james_w 4 years ago.
Possible patch for this issue.

Change History

Changed 4 years ago by james_w

Possible patch for this issue.

Changed 4 years ago by james_w

  • cc jw+debian@… added

Changed 3 years ago by lennart

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to Avahi 0.6.24

Fixed in r17a87e365175dac3682735710522695b7e5a6bdc.

Note: See TracTickets for help on using tickets.