Ticket #226 (closed defect: fixed)

Opened 6 months ago

Last modified 4 weeks ago

avahi-discover crashes if row is unselected

Reported by: james_w Assigned to: lennart
Priority: minor Milestone: Avahi 0.6.24
Component: avahi-python Version:
Keywords: Cc: jw+debian@jameswestby.net

Description

Hi,

In

https://bugs.launchpad.net/bugs/230337

a user reported that avahi-discover crashed for them.

Traceback (most recent call last):

File "/usr/bin/avahi-discover", line 64, in on_tree_view_cursor_changed

(name,interface,protocol,stype,domain) = self.treemodel.get(iter,1,2,3,4,5)

TypeError?: iter must be a GtkTreeIter?

I believe the cause of this was the a row was unselected, meaning that get_selection() returned None for iter, which then was used improperly in treemodel.get()

The attached patch should prevent this from happening. Please consider applying it.

Thanks,

James

Attachments

avahi-discover.diff (0.7 kB) - added by james_w on 07/26/08 12:27:49.
Possible patch for this issue.

Change History

07/26/08 12:27:49 changed by james_w

  • attachment avahi-discover.diff added.

Possible patch for this issue.

07/26/08 12:29:54 changed by james_w

  • cc set to jw+debian@jameswestby.net.

12/12/08 20:42:05 changed by lennart

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone set to Avahi 0.6.24.

Fixed in r17a87e365175dac3682735710522695b7e5a6bdc.