Ticket #180 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

Override service types displayed by AuiServiceDialog

Reported by: MathiasHasselmann Assigned to: lennart
Priority: major Milestone: Avahi 0.6.22
Component: avahi-ui Version:
Keywords: Cc:

Description

When running AuiServiceDialog? with multiple service types it shows a column displaying the type of the service found. This column has problems:

- When the service is not registered in the service types database the very technical DNS-SD type is shown, instead of something human readable. Scary. - When using the dialog to select for instance HTTP and HTTPS services, the currently shown text ("Web Site" and "Secure Web Site") might be too verbose in the application's context. Labels like "Secure" and "Insecure" might be more useful.

So I suggest adding this API to AuiServiceDialog?:

void aui_service_dialog_set_service_type_caption (AuiServiceDialog *d,
                                                  const gchar      *type,
                                                  const gchar      *caption);

which adds the key/value pair to a hashtable overriding the values found in the database.

Attachments

0001-Reduce-warning-storm-in-libavahi-ui.patch (6.6 kB) - added by MathiasHasselmann on 11/09/07 13:39:04.
0002-Add-aui_service_dialog_set_service_type_name-and-re.patch (6.1 kB) - added by MathiasHasselmann on 11/09/07 13:39:24.
0003-Don-t-show-table-header-when-type-column-becomes-vis.patch (2.2 kB) - added by MathiasHasselmann on 11/09/07 13:39:32.

Change History

11/09/07 13:39:04 changed by MathiasHasselmann

  • attachment 0001-Reduce-warning-storm-in-libavahi-ui.patch added.

11/09/07 13:39:24 changed by MathiasHasselmann

  • attachment 0002-Add-aui_service_dialog_set_service_type_name-and-re.patch added.

11/09/07 13:39:32 changed by MathiasHasselmann

  • attachment 0003-Don-t-show-table-header-when-type-column-becomes-vis.patch added.

11/09/07 13:41:41 changed by MathiasHasselmann

Regarding the 3rd patch: I consider the table header useless clutter when service name and type are shown. My opinion might be slightly different, when the header would allow sorting, but it doesn't. If you disagree regarding that visibility of the header should be a dialog property I guess.

11/09/07 14:18:24 changed by lennart

(In [1568]) Reduce warning storm in libavahi-ui, contributed by Matthias Hasselmann (Re #180)

11/09/07 14:42:36 changed by lennart

(In [1570]) Allow overwriting of pretty service names. Add new tool bshell as combination of bssh and bnc. Patch from Mathias Hasselmann. Re #180. (Also fixing a va_copy misuse)

11/09/07 14:46:24 changed by lennart

  • status changed from new to closed.
  • type changed from defect to enhancement.
  • resolution set to fixed.

Uh, and in r1571 i commited the third patch.

Mathias, thanks for the patches!

11/09/07 14:46:31 changed by lennart

  • milestone set to Avahi 0.6.22.