Ticket #148 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

libdaemon's daemon_close_all() stargs usage is wrong

Reported by: dcbw Assigned to: lennart
Priority: major Milestone: Avahi 0.6.21
Component: other Version:
Keywords: Cc:

Description

It's only called with except_fd = -1, but the code assumes there will be more arguments. Therefore, it runs through random memory in the for loops trying to get the end of the varargs argument list, which is garbage memory because there arne't any.

Attachments

libdaemon-0.11-stdarg-fix.patch (1.2 kB) - added by dcbw on 07/02/07 20:54:15.

Change History

07/02/07 20:54:15 changed by dcbw

  • attachment libdaemon-0.11-stdarg-fix.patch added.

07/02/07 20:54:53 changed by dcbw

The code needs to treat except_fd as the first argument, and all the stdargs arguments as additional to except_fd.

07/10/07 23:38:49 changed by lennart

  • status changed from new to closed.
  • resolution set to fixed.
  • component changed from avahi-core to other.

Fixed in libdaemon 0.12. Thanks!

(I will update the Fedora packages soonish, although this is not really necessary because the 0.12 release doesn't bring anything new besides your fix which is included in the current packages anyway)

08/12/07 17:48:56 changed by lennart

  • milestone set to Avahi 0.6.21.