Ticket #111 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

avahi-discover.desktop.in shouldn't use icons from gnome-nettool

Reported by: ahanke Owned by: lathiat
Milestone: Avahi 0.6.18 Component: avahi-python
Keywords: Cc:

Description

avahi-discover.desktop.in currently has "Icon=gnome-nettool". This causes a circular dependency, which should be avoided by using a local copy of the icon under a different filename (or a totally different icon).

The dependency loop is:

- gnome-vfs can be compiled with avahi support, which makes it depend on avahi - gnome-nettool always requires gnome-vfs - avahi-discover.desktop uses an icon from gnome-nettool, therefore it requires gnome-nettool

gnome-vfs requires avahi requires gnome-nettool requires gnome-vfs.

The current situation forces some distributors to do local workarounds, which is ugly (.desktop files that differ from upstream can cause "interesting" problems):

http://lists.opensuse.org/opensuse-commit/2007-01/msg01138.html

Change History

Changed 5 years ago by lathiat

  • owner changed from lennart to lathiat
  • status changed from new to assigned

Howdy,

Thanks for your bug report, I will investigate including an icon in the Avahi source.

Cheers, Trent

Changed 5 years ago by lathiat

  • status changed from assigned to new

Changed 5 years ago by lathiat

  • status changed from new to assigned

Changed 5 years ago by lennart

humm, honestly, i don't really see this as a circular dependency problem. If gnome-nettool is not available, a blank icon is shown. And where's the problem?

Anyway, I will change that to "network-wired" now. That's a Tango icon name, and I guess that's a better choice since we no longer steal the icon from gnome-nettool and you're happy.

Changed 5 years ago by lennart

  • status changed from assigned to closed
  • resolution set to fixed

(In [1416]) use network-wired instead of gnome-nettool as an icon. Stealing icons sucks. network-wired is a Tango icon name, hence probably a better thing to use. Closes #111

Changed 4 years ago by lennart

  • milestone set to Avahi 0.6.18
Note: See TracTickets for help on using tickets.